Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the dataset version in the heatwaves_coldwaves recipe to avoid the "Unknown file format" issue on JASMIN #3373

Merged

Conversation

ehogan
Copy link
Contributor

@ehogan ehogan commented Oct 6, 2023

Description

I tested the recipe on JASMIN with these changes and it works :)


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@ehogan
Copy link
Contributor Author

ehogan commented Oct 6, 2023

@esmvalbot Please run recipe_heatwaves_coldwaves.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2023

Since @ehogan asked, ESMValBot will run recipe recipe_heatwaves_coldwaves.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2023

ESMValBot is sorry to report it failed to run recipe recipe_heatwaves_coldwaves.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

@esmvalbot Please run recipe_heatwaves_coldwaves.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 9, 2023

Since @valeriupredoi asked, ESMValBot will run recipe recipe_heatwaves_coldwaves.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 9, 2023

ESMValBot is sorry to report it failed to run recipe recipe_heatwaves_coldwaves.yml: exit is 1, output has been generated here

@bouweandela
Copy link
Member

@esmvalbot Please run recipe_heatwaves_coldwaves.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 10, 2023

Since @bouweandela asked, ESMValBot will run recipe recipe_heatwaves_coldwaves.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 10, 2023

ESMValBot is sorry to report it failed to run recipe recipe_heatwaves_coldwaves.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

Hahah do you think we can hammer the bot into succeeding @bouweandela ? 😁 There's an actual issue with the poor thing - that's why I asked who's its caretaker now that Remi left

@bouweandela
Copy link
Member

@esmvalbot Please run recipe_heatwaves_coldwaves.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 10, 2023

Since @bouweandela asked, ESMValBot will run recipe recipe_heatwaves_coldwaves.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 10, 2023

ESMValBot is sorry to report it failed to run recipe recipe_heatwaves_coldwaves.yml: exit is 1, output has been generated here

@bouweandela
Copy link
Member

Hahah do you think we can hammer the bot into succeeding @bouweandela ? 😁

Worth a try ;-)

There's an actual issue with the poor thing - that's why I asked who's its caretaker now that Remi left

Let's talk about that at the next tech lead team meeting

@valeriupredoi valeriupredoi added this to the v2.10.0 milestone Oct 12, 2023
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving this and adding M2.10 to it since it's such a quick PR, if only the bot was playing ball

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 19, 2023

I did the bot's job and ran this recipe off this branch on Levante, all went well, so am merging this, cheers for your good work @ehogan 🍺

@valeriupredoi valeriupredoi merged commit 097e629 into main Oct 19, 2023
6 checks passed
@valeriupredoi valeriupredoi deleted the 3371_add_dataset_version_to_heatwaves_coldwaves_recipe branch October 19, 2023 11:37
@valeriupredoi
Copy link
Contributor

@esmvalbot Please run recipe_heatwaves_coldwaves.yml

@esmvalbot
Copy link

esmvalbot bot commented Nov 9, 2023

Sorry, ESMValBot can not find recipe_heatwaves_coldwaves.yml recipe in ESMValGroup/ESMValTool repo at 3371_add_dataset_version_to_heatwaves_coldwaves_recipe branch, please check that recipe name is correct

@valeriupredoi
Copy link
Contributor

@esmvalbot Please run examples/recipe_python.yml

@esmvalbot
Copy link

esmvalbot bot commented Nov 9, 2023

Sorry, ESMValBot can not find examples/recipe_python.yml recipe in ESMValGroup/ESMValTool repo at 3371_add_dataset_version_to_heatwaves_coldwaves_recipe branch, please check that recipe name is correct

@bouweandela
Copy link
Member

The branch has been deleted, you'll need to click the restore button if you want to use it.

@valeriupredoi
Copy link
Contributor

took me a minute to figure that out, then promptly hijacked the first active PR in our repo 🤣

jvegreg pushed a commit that referenced this pull request Jan 14, 2024
…e "Unknown file format" issue on JASMIN (#3373)

Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the dataset version in the heatwaves_coldwaves recipe to avoid the "Unknown file format" issue on JASMIN
3 participants