Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build #3397

Merged
merged 1 commit into from Oct 26, 2023
Merged

Fix documentation build #3397

merged 1 commit into from Oct 26, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Oct 26, 2023

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

@bouweandela bouweandela marked this pull request as ready for review October 26, 2023 07:55
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I guess setting it to False works too - but do we not want navigation with keys?nI mean, when they fix their next page -> bug

@bouweandela
Copy link
Member Author

It looks like they're disabling it by default because it doesn't work well. I've never used it anyway, you?

@valeriupredoi
Copy link
Contributor

It looks like they're disabling it by default because it doesn't work well. I've never used it anyway, you?

yes! when there are long code snippets, how do you scroll horizontally? I always go RightKey/LeftKey

@valeriupredoi valeriupredoi merged commit 3e7ff21 into main Oct 26, 2023
6 checks passed
@valeriupredoi valeriupredoi deleted the fix-docs branch October 26, 2023 12:48
@bouweandela
Copy link
Member Author

I just make the browser window full-screen ;-)

jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation build is failing
2 participants