New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed plot paths in NCL provenance tracking #3422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklaus
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the Ncl recipes and this is definitively a big step forward. Some recipes fail for other reasons, but let's get it in and work from there.
bouweandela
pushed a commit
that referenced
this pull request
Dec 13, 2023
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
jvegreg
pushed a commit
that referenced
this pull request
Jan 14, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
jvegreg
pushed a commit
that referenced
this pull request
Jan 14, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
flicj191
pushed a commit
that referenced
this pull request
Feb 6, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, many plot paths in NCL diagnostics are invalid. Since #3332, this leads to errors in the corresponding diagnostics (see also #3414). This PR fixes those and also makes sure to output a proper error message if an invalid plot path is used to prevent this issue in the future.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: