Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed plot paths in NCL provenance tracking #3422

Merged
merged 6 commits into from Nov 22, 2023
Merged

Fixed plot paths in NCL provenance tracking #3422

merged 6 commits into from Nov 22, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 14, 2023

Description

Currently, many plot paths in NCL diagnostics are invalid. Since #3332, this leads to errors in the corresponding diagnostics (see also #3414). This PR fixes those and also makes sure to output a proper error message if an invalid plot path is used to prevent this issue in the future.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added this to the v2.10.0 milestone Nov 14, 2023
@schlunma schlunma requested a review from zklaus November 14, 2023 16:39
@schlunma
Copy link
Contributor Author

Note: I did not run any recipe (these are way too many). @zklaus could you maybe run the tests from #3414 again with only the NCL recipes?

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the Ncl recipes and this is definitively a big step forward. Some recipes fail for other reasons, but let's get it in and work from there.

@zklaus zklaus merged commit 1647d46 into main Nov 22, 2023
6 checks passed
@zklaus zklaus deleted the fix_ncl_prov branch November 22, 2023 13:28
bouweandela pushed a commit that referenced this pull request Dec 13, 2023
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
flicj191 pushed a commit that referenced this pull request Feb 6, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ncl log_provenance in interface_script seems broken
2 participants