Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of JRA-25 CMORizer #3470

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

New version of JRA-25 CMORizer #3470

wants to merge 10 commits into from

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Dec 13, 2023

Description

Please note: this PR requires ESMValCore PR ESMValGroup/ESMValCore#2277.

This PR replaces the existing CMORizer for the reanalysis JRA-25 that uses CREATE-IP data with a version that uses data from the NCAR Research Data Archive (RDA). RDA provides more variables (e.g. cloud variables) than available via CREATE-IP. New variables include:

  • cl
  • clwvi
  • tcw (total cloud water, custom variable)

In addition, also the following variables were added:

  • ta
  • tas

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated data reformatting script

Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded all the data (took a while) with the downloader, and cmorized it with the formatter. All worked fine. I checked the data files and they seem correct (unit-wise, latitude/longitude-wise, magnitude-wise...). Good to go from my side, @axel-lauer!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, guys! Could you please fix the failing test, then I can merge 馃嵑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants