Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous file_type handling in certain NCL diagnostics #3474

Merged
merged 2 commits into from Dec 14, 2023

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Dec 14, 2023

Description

Several diagnostic scripts try to guess the name of the plot result file. However, the way that they are determined is different and the guess is wrong. This PR changes this by using the actual filename as given by the wks.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@zklaus zklaus marked this pull request as ready for review December 14, 2023 15:12
@bouweandela bouweandela merged commit 4cbb246 into main Dec 14, 2023
6 checks passed
@bouweandela bouweandela deleted the fix-ncl-plot-file-handling branch December 14, 2023 15:13
@bouweandela bouweandela added this to the v2.10.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants