Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pys2index dependency #3577

Merged
merged 1 commit into from Apr 24, 2024
Merged

Adding pys2index dependency #3577

merged 1 commit into from Apr 24, 2024

Conversation

ljoakim
Copy link
Contributor

@ljoakim ljoakim commented Apr 24, 2024

Description

This PR adds the pys2index dependency, which is needed by the AERONET cmorizer (#3227, still in progress). The purpose of this PR is to have the pys2index package added to the environment in the image used when running tests on Circle, which will fix tests in #3227 failing due to this missing dependency.

pys2index has been added to setup.py as well, but is commented out to avoid same type of test fails as in #3227. This will be uncommented in that PR when this has been merged.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

@ljoakim ljoakim self-assigned this Apr 24, 2024
@ljoakim ljoakim changed the title Adding pys2index in dependency lists Adding pys2index dependency Apr 24, 2024
@ljoakim ljoakim marked this pull request as ready for review April 24, 2024 07:54
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @ljoakim 🍺

@valeriupredoi valeriupredoi merged commit 696097c into main Apr 24, 2024
8 checks passed
@valeriupredoi valeriupredoi deleted the pys2index-dependency branch April 24, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pys2index dependency
2 participants