Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed attribute handling in emergent constraint diagnostic for iris>=3.8 #3605

Merged
merged 1 commit into from
May 21, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented May 21, 2024

Description

Since version 3.8, iris distinguishes explicitly between local and global attributes (see ESMValGroup/ESMValCore#2398), which causes an error in the emergent constraint diagnostics. This PR fixes that.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Manu (heroic PR off a train to Jena at 6am 🎖️ )

@valeriupredoi valeriupredoi merged commit 7513b72 into main May 21, 2024
8 checks passed
@valeriupredoi valeriupredoi deleted the fix_schlund20esd branch May 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostic failure for recipe_schlund20esd.yml on v2.11.0rc1
2 participants