Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a data download link to the running your first recipe episode #100

Closed
wants to merge 2 commits into from

Conversation

bouweandela
Copy link
Member

Pull Request checklist

Add a data download link to the running your first recipe episode. @sverhoeven Something like this? Or should the link go somewhere else?


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Related to #54

Copy link
Contributor

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I was able to run the example and see plots by downloading the file to ~/default_inputpath/ and
commenting out a line in ~/.esmvaltool/config-user.yml .

_episodes/04-recipe.md Outdated Show resolved Hide resolved
Comment on lines +276 to +282
> The example recipe presented above requires a single data file. If you are not
> working on a system with data available, you can download the file with the
> command:
>
> ~~~bash
> wget http://esgf-data1.ceda.ac.uk/thredds/fileServer/esg_dataroot/cmip5/output1/MOHC/HadGEM2-ES/historical/mon/ocean/Omon/r1i1p1/v20110916/thetaoga/thetaoga_Omon_HadGEM2-ES_historical_r1i1p1_185912-200512.nc
> ~~~
Copy link
Contributor

@sverhoeven sverhoeven Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section might be better placed on setup.md

Also if we tell user to download to ~/default_inputpath/ we can reduce some typing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that people will not be able to find it in that very long document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #103

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #104 is merged we should point to that section of the setup.md instead of having the command here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for that before continuing with this PR then

Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
@Peter9192
Copy link
Contributor

@bouweandela Can this be closed (since #54 is merged)?

@bouweandela bouweandela deleted the esgf-link branch September 25, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants