Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GitHub action workflow to check Markdown #55

Merged
merged 19 commits into from
Jul 3, 2020
Merged

use GitHub action workflow to check Markdown #55

merged 19 commits into from
Jul 3, 2020

Conversation

sverhoeven
Copy link
Contributor

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes {Link to the corresponding issue}

@Peter9192
Copy link
Contributor

Why build for push and PR? Wouldn't one of them be enough?

@sverhoeven sverhoeven marked this pull request as ready for review July 2, 2020 09:04
@sverhoeven
Copy link
Contributor Author

GitHub action fails as expected due to check errors, see log of GitHub action job to see the errors.

@sverhoeven
Copy link
Contributor Author

Why build for push and PR? Wouldn't one of them be enough?

Push is for commits to this repo and PR also runs for external PRs. So we need both.

@sverhoeven sverhoeven requested a review from Peter9192 July 3, 2020 08:03
@sverhoeven
Copy link
Contributor Author

Once merged we should fix the lint errors and disable codacy.

@Peter9192
Copy link
Contributor

Very nice @sverhoeven! I'll merge this, open a new issue for existing problems, and disable codacy.

Cheers!

@Peter9192 Peter9192 merged commit 56d2232 into master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants