-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use GitHub action workflow to check Markdown #55
Conversation
We use *.md instead of *.Rmd Use minimal minor ruby version from Gemfile
Why build for push and PR? Wouldn't one of them be enough? |
GitHub action fails as expected due to check errors, see log of GitHub action job to see the errors. |
Push is for commits to this repo and PR also runs for external PRs. So we need both. |
Once merged we should fix the lint errors and disable codacy. |
Very nice @sverhoeven! I'll merge this, open a new issue for existing problems, and disable codacy. Cheers! |
Pull Request checklist
We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.
Before you start
Tasks
Lesson development
section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.Lesson organization
andLesson formatting
sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.make serve
, alternativelymake docker-serve
. Please see thePreviewing your changes locally
section in CONTRIBUTING.md for installation instructions.If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes {Link to the corresponding issue}