Add missing return in BleFingerprint::fingerprintServiceAdvertisements / Fix incorrect check in hextostr() #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't _strictly_ required because setId() ignores "downgrades" to more generic ID types (i.e. from ID_TYPE_FLORA to ID_TYPE_AD in this case) but skips running unnecessary code and makes the code more readable.
This function decodes hex-encoded strings (e.g. "41" -> "A"). Previously we'd check whether the output buffer's size is a multiple of two. This would incorrectly reject valid uses of the function. Instead we should check the input string's length.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing return in BleFingerprint::fingerprintServiceAdvertisements
This isn't strictly required because
setId()ignores "downgrades" to more generic ID types (i.e. fromID_TYPE_FLORAtoID_TYPE_ADin this case) but skips running unnecessary code and makes the code more readable.Fix incorrect check in hextostr()
This function decodes hex-encoded strings (e.g. "41" -> "A"). Previously we'd check whether the output buffer's size is a multiple of two. This would incorrectly reject valid uses of the function. Instead we should check the input string's length.