Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Network.h #734

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update Network.h #734

merged 1 commit into from
Nov 30, 2022

Conversation

mjtimmer
Copy link
Contributor

Add ethernet support for GL-inet GL-S10.

Add ethernet support for GL-inet GL-S10.
Copy link
Contributor

@DTTerastar DTTerastar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but you also need to add it to the dropdown via the settings so you can pick it.

@DTTerastar
Copy link
Contributor

This line:

std::vector<String> ethernetTypes = {"None", "WT32-ETH01", "ESP32-POE", "WESP32", "QuinLED-ESP32", "TwilightLord-ESP32", "ESP32Deux", "KIT-VE", "LilyGO-T-ETH-POE"};

@mjtimmer mjtimmer mentioned this pull request Nov 29, 2022
@mjtimmer
Copy link
Contributor Author

Thanks! I'm still very new to Github (and coding) ;)
Created pull request #735 for the addition to main.cpp

@DTTerastar DTTerastar merged commit 2cd9a30 into ESPresense:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants