Apply missing review changes and do some fixes #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-oliveira95
requested review from
nicoddemus,
prusse-martin,
cauebs and
BeneBr
ro-oliveira95
force-pushed
the
fb-ASIM-5600-apply-missing-review-changes
branch
from
5e03081
to
f4c67c8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## fb-ASIM-5256-history-matching-results-management #370 +/- ##
====================================================================================
+ Coverage 99.95% 99.97% +0.01%
====================================================================================
Files 55 55
Lines 6951 6964 +13
====================================================================================
+ Hits 6948 6962 +14
+ Misses 3 2 -1 |
|
ro-oliveira95
changed the title
nicoddemus
approved these changes
Mar 13, 2024
prusse-martin
approved these changes
Mar 13, 2024
ro-oliveira95
merged commit 3a8ef33
into
fb-ASIM-5256-history-matching-results-management
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#364 was merged without applying the changes suggested in the reviews. This PR was created to address this and to fix minor things that had popup in the base branch CI.