feat(NgXform): validate all fields on submit #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edetec
commented
Sep 18, 2018
edetec
commented
- Change validation message color to red
- validate all fields on submit
Pull Request Test Coverage Report for Build 350
💛 - Coveralls |
igortg
reviewed
Sep 19, 2018
src/ng-xform/ng-xform.component.html
Outdated
| <ng-xform-form-group [isHorizontal]="horizontalForm" [labelWidth]="labelWidth" [fields]='fields' [form]=form [editing]='editing'></ng-xform-form-group> | ||
| <div class="row"> | ||
| <div class=" col-sm-12 text-right"> | ||
| <button type="submit" class="btn btn-primary" (click)="setEditing(true)" *ngIf="editing === false"> |
There was a problem hiding this comment.
Are we going to keep the buttons bar inside <form> tag?
There was a problem hiding this comment.
I forgot it, I'll change back.
| @@ -80,7 +80,19 @@ export class NgXformComponent implements OnInit, OnChanges { | |||
| return modelToSend; | |||
| } | |||
|
|
|||
| validateAllFormFields(formGroup: FormGroup) { | |||
| Object.keys(formGroup.controls).forEach(field => { | |||
| const control = formGroup.get(field); | |||
There was a problem hiding this comment.
Just being picky, but wouldn't be more correct to define const control outside the loop?
There was a problem hiding this comment.
In this case, because const receives control of the iteration field and is valid only for the scope of the arrow function.
lvoliveira
approved these changes
Sep 19, 2018
igortg
approved these changes
Sep 20, 2018
lincrosenbach
approved these changes
Sep 20, 2018
feat(DateRangeField): add Date range field support
feat(DateRangeField): add Date range field support feat(SelectField): add flag to force search on first focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.