Read only fields #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 77
💛 - Coveralls |
lvoliveira
requested changes
Feb 28, 2018
| <div *ngIf="!editing" id="{{field.key}}-label"> | ||
| <strong>{{ field.label }}</strong> | ||
| <div *ngIf="!isEditing" id="{{field.key}}-label"> | ||
| <strong>{{ field.label }}</strong> <small *ngIf="isOptional" style="color: gray">(optional)</small> |
There was a problem hiding this comment.
Shouldn't the 'optional' part be only in the editable div? It will never be used here.
|
|
||
| get isOptional(): boolean { | ||
| return this.editing && !this.field.readOnly && |
There was a problem hiding this comment.
You would avoid testing if it is 'editing' if you remove the 'optional' part from the div in the non-editing state.
| <strong *ngIf="!editing">{{ field.label }}</strong> | ||
| <p class="text-muted" *ngIf="!editing">{{ form?.controls[elementId]?.value | valueSuffix: field.unit }}</p> | ||
| <div *ngIf="!isEditing" id="{{elementId}}-label"> | ||
| <strong>{{ field.label }}</strong> <small *ngIf="isOptional" style="color: gray">(optional)</small> |
| <div *ngIf="!editing" id="{{field.key}}-label"> | ||
| <strong>{{ field.label }}</strong> | ||
| <div *ngIf="!isEditing" id="{{field.key}}-label"> | ||
| <strong>{{ field.label }}</strong> <small *ngIf="isOptional" style="color: gray">(optional)</small> |
| <div [hidden]="editing" id="{{field.key}}-label"> | ||
| <strong>{{ field.label }}</strong> | ||
| <div [hidden]="isEditing" id="{{field.key}}-label"> | ||
| <strong>{{ field.label }}</strong> <small *ngIf="isOptional" style="color: gray">(optional)</small> |
igortg
reviewed
Mar 1, 2018
demo/src/app/home/home.component.ts
Outdated
| @@ -44,6 +43,14 @@ export class HomeComponent implements OnInit { | |||
| Validators.email | |||
| ] | |||
| }), | |||
| new SelectField({ | |||
There was a problem hiding this comment.
A read-only SelectField doesn't make much sense. But ok, we can review that later
| @@ -53,6 +53,10 @@ export class SelectFieldComponent extends BaseDynamicFieldComponent<SelectField> | |||
| this.select.registerOnTouched(this._onTouched); | |||
| this.viewModel.subscribe((value: any) => { | |||
| if (this.field.searchByValueAttributeHandler) { | |||
| if (value === undefined || value === null) { | |||
There was a problem hiding this comment.
If initialize the FormControl with undefined value or call form.setValue with undefined for the key of this control
lvoliveira
approved these changes
Mar 2, 2018
igortg
suggested changes
Mar 2, 2018
| <div *ngIf="editing" id="{{elementId}}-div" class="form-group" [formGroup]="form" [ngClass]="displayFieldCss()"> | ||
| <label for="{{elementId}}">{{field.label}}</label> | ||
| <div *ngIf="isEditing" id="{{elementId}}-div" class="form-group" [formGroup]="form" [ngClass]="displayFieldCss()"> | ||
| <label for="{{elementId}}">{{field.label}}</label> <small *ngIf="isOptional" style="color: gray">(optional)</small> |
There was a problem hiding this comment.
DRY!
Optional should be a component named <optional-tag> or something alike.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add read-only behavior, and display '(optional)' label for not required fields