Update setEdgeTerminal to remove unused ports from style #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haensch-mauricio
commented
Dec 3, 2021
haensch-mauricio
requested review from
dettmerramon,
nicoddemus and
prusse-martin
nicoddemus
requested changes
Dec 3, 2021
haensch-mauricio
force-pushed
the
fb-ASIM-4512-links-data
branch
from
b87f311
to
1fb0ac4
Compare
prusse-martin
approved these changes
Dec 7, 2021
| assert ( | ||
| graph.eval_js_function('graphs.utils.setStyleKey', 'foobar=3', 'bar', 5) == 'foobar=3;bar=5' | ||
| ) | ||
| assert ( |
There was a problem hiding this comment.
Not a problem.
Don't need to change.
A formatting nitpick.
I think that using a partial will prevent precommit hook from breaking those lines.
set_style_key = partial(graph.eval_js_function, 'graphs.utils.setStyleKey')
assert set_style_key('foobar=3;fizzbar=7', 'bar', 5) == 'foobar=3;fizzbar=7;bar=5'There was a problem hiding this comment.
On that topic, is there a JS autoformatter we can use with pre-commit?
EDIT: https://prettier.io?
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
@oliveira-mauricio don't worry about doing it in this PR though, we can add the configuration in a follow up.
There was a problem hiding this comment.
Sure, I will create a task to tackle that later.
|
Docs generation is broken on master. |
added 6 commits
December 10, 2021 10:24
…d with bar=5 would update foobar instead)
haensch-mauricio
force-pushed
the
fb-ASIM-4512-links-data
branch
from
8058d2b
to
46fd752
Compare
prusse-martin
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.