problem: no visual indicator for importing private key #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
force-pushed
the
fix/import-loading-ui
branch
from
9756ea2
to
0f26548
Compare
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
- Coverage 18.45% 18.41% -0.04%
==========================================
Files 198 198
Lines 3035 3041 +6
Branches 523 524 +1
==========================================
Hits 560 560
- Misses 2081 2086 +5
- Partials 394 395 +1
Continue to review full report at Codecov.
|
shanejonas
force-pushed
the
fix/import-loading-ui
branch
from
0f26548
to
c7d4462
Compare
solution: loading indicator on button and take importing off render thread with ipc
shanejonas
force-pushed
the
fix/import-loading-ui
branch
from
c7d4462
to
70f8e11
Compare
gagarin55
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution: loading indicator on button and take importing off render thread with ipc
fixes #440