Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming for etcommon-bigint #61

Open
pyskell opened this issue Mar 16, 2018 · 1 comment
Open

Inconsistent naming for etcommon-bigint #61

pyskell opened this issue Mar 16, 2018 · 1 comment

Comments

@pyskell
Copy link

pyskell commented Mar 16, 2018

To use etcommon-bigint you need to specify it as etcommon-bigint in your Cargo.toml but as bigint in your main.rs.

Example:
Cargo.toml:

[dependencies]
etcommon-bigint = "0.2.9"

main.rs:

extern crate bigint;

I believe this mismatch is due to the following in https://github.com/ETCDEVTeam/etcommon-rs/blob/master/bigint/Cargo.toml#L11:

[lib]
name = "bigint"

I realize changing this now would break dependencies but it is a bit confusing when trying to work with the library so maybe adding a note to the docs would be helpful? If so I can submit a PR next week.

@whilei
Copy link

whilei commented Mar 21, 2018

That would be great @pyskell, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants