Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: JUMPDEST recursive attack #161

Closed
sorpaas opened this issue Jun 2, 2017 · 1 comment
Closed

Performance: JUMPDEST recursive attack #161

sorpaas opened this issue Jun 2, 2017 · 1 comment

Comments

@sorpaas
Copy link
Contributor

sorpaas commented Jun 2, 2017

This has been fixed in other EVMs long time ago. See ethereum/go-ethereum#1150 and ethereum/go-ethereum#1150
@sorpaas
Copy link
Contributor Author

sorpaas commented Jun 2, 2017

Part of #162.

@sjmackenzie sjmackenzie mentioned this issue Jun 3, 2017
Closed
@sorpaas sorpaas changed the title Problem: JUMPDEST recursive attack Performance: JUMPDEST recursive attack Jun 8, 2017
@sorpaas sorpaas closed this as completed Jun 13, 2017
@sorpaas sorpaas reopened this Jun 13, 2017
@sorpaas sorpaas mentioned this issue Oct 23, 2017
Merged
sorpaas added a commit that referenced this issue Oct 24, 2017
@sorpaas
Wrap immutable fields into Rc to avoid copying
193897f 
Fix #161.

Wrapping field in Rc makes it so that only a pointer is needed to be
copied for every callstack push.

* Account code: can only be created or deleted.
* Context code: same as account code.
* Context data: cannot be changed during VM execution.
* Out: can only be set by RETURN, and is not changable individually
  for its indexes.
@sorpaas sorpaas mentioned this issue Oct 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorpaas