Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commenting code #5

Closed
wants to merge 1 commit into from
Closed

Conversation

aixasz
Copy link

@aixasz aixasz commented Aug 8, 2017

Why we need to keep it?

@aixasz aixasz mentioned this pull request Aug 8, 2017
@ultimaweapon
Copy link
Contributor

I think this one is hard to review. Should we remove commented code per-category instead? Something like Remove unused codes related to SQLite? Any idea?

BTW, why we talk in English? I think it weird since README is in Thai.

@pragasitcha
Copy link
Contributor

เรียนคุณ @ExUltima @aixasz

ค่อนข้างเป็นการยากจริงๆครับ ที่จะ review comment ทิ้งไว้ทั้งหมด
อย่างไรก็ตาม ทางทีมจะทำการ ลบ comment ที่ไม่มีการใช้ออกจาก code ในเวอร์ชันถัดไปตามคำแนะนำครับ

ขอบคุณสำหรับ feedback จากทางทั้งสองท่านครับ

@aixasz aixasz deleted the remove-commenting-code branch September 12, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants