Extension build process #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DrLynch Have you gotten a chance to review this process yet? We ought to get this merged in. |
pmitros
reviewed
Jul 5, 2023
| "description": "Tracks writing in Google Docs, and provides nifty insights to you and your teachers!", | ||
| "version": "0.0.1", | ||
| "homepage": "http://chrome.google.com/webstore", | ||
| "author": "ENTER YOUR NAME HERE", |
pmitros
reviewed
Jul 5, 2023
| "author": "ENTER YOUR NAME HERE", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "ENTER GIT REPO URL" |
There was a problem hiding this comment.
Enter https://github.com/ETS-Next-Gen/writing_observer here (or even the path to the extension)
|
As per our conversation, I would be inclined to merge this sooner rather than later (e.g. when my two comments are addressed), and then keep working from there. We do also need to check for outstanding issues on the NCSU side, to avoid merge conflicts. Once the two changes are made, and we're clear with NCSU, I approve merge. |
|
@DrLynch we decided to merge this at it was a blocking step for Piotr. We can continue to work on beyond this. |
|
That's fine Brad I will try it out in any case and send comments when I get time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.