Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dotpay CHK parameter support and Symfony version requirments. #3

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

pawellen
Copy link

1 changed:
Symfony version requirments change to <2.4

1 added:
Added support of CHK parameter. CHK parameter is used by dotpay do sing payment request. It is used to avoid generation of payments by anyone. The problem is that anyone can use this form https://ssl.dotpay.pl/payment/index.php or send false request to doypay about new payment. In this case you can generate many 0,01 transaction for witch the DotPay customer have to pay fee. The CHK parameter can be enabled by contact dotpay support tech@dotpay.pl. Email must be send from email associated with dotpay account.

@@ -97,7 +103,7 @@ class DotpayDirectPlugin extends AbstractPlugin
* @param integer $type The type
* @param string $returnUrl The return url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the parameter to the param list

@ClementGautier
Copy link
Contributor

Please:

  • do the code review
  • add a test for the generateChk function
  • squash your commits using rebase

After that I will merge ;)

@pawellen
Copy link
Author

Okej, I will do all the stuff, sorry for mess in my code, big thx for help!! :)

maciek and others added 9 commits October 17, 2013 10:42
Added option to change payment description
Bug fix for: PHP Fatal error:  Call to undefined function ETS\\Payment\\DotpayBundle\\Tools\\normalizer_normalize() in /home/www/econtenta/vendor/ets/payment-dotpay-bundle/ETS/Payment/DotpayBundle/Tools/String.php
@ch3ric
Copy link
Contributor

ch3ric commented Jan 29, 2014

@pawellen @maciek thanks for this PR!

Please

support for dotpay exception when user hit back button in browser and 2 status is sent first is failed and the completed
@ch3ric
Copy link
Contributor

ch3ric commented Mar 11, 2016

Hi @pawellen,

I'd love to merge all the features you added in this PR.
Could you please squash your commits and rebase so that we can merge.
Also it would be great to add some phpunits for the methods generateChk and generateRecipientChk

Thanks

@nicolas-grevin
Copy link
Contributor

This PR has has moved to #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants