Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Batch client work with PIDClientCredentials #13

Closed
TobiasWeigel opened this issue Oct 12, 2017 · 3 comments
Closed

Make Batch client work with PIDClientCredentials #13

TobiasWeigel opened this issue Oct 12, 2017 · 3 comments

Comments

@TobiasWeigel
Copy link
Contributor

The PIDClientCredentials is a good class to conveniently cover all possible authentication cases and get the information either through function calls or from a JSON file.
The batch client has however its own methods. To use both clients transparently, the batch client should be able to work with PIDClientCredential instances as well (e.g. via a generic authenticate() method that takes a PIDClientCredentials instance as only parameter).

@TobiasWeigel
Copy link
Contributor Author

One further issue may be that if private key authentication is to be used, it is logically nto required to provide a password in the credentials file. However, omitting a password will cause the credentials file read method to throw an error, complaining that without password, searchign will not be possible.
Suggested solution: modify credentials JSON read method so that possibility for searches is not checked if a specific flag parameter is given. Or make a subclass that is specific for the REST mode and only there the error will be thrown.

@SofianeB
Copy link
Collaborator

SofianeB commented Mar 5, 2018

#17 resolves this.

@SofianeB
Copy link
Collaborator

First issue solved by #17 and create new issue for #13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants