adding test for assert_docker()

prosper/common/test_helpers.py

@@ -31,8 +31,6 @@ def assert_docker(xfail=False, force_retry=False, **kwargs):
         return
 
     if xfail:
-        raise pytest.xfail(
-            'Docker Not available: {!r}'.format(err)  # TODO: this seems bad af
-        )
+        raise pytest.xfail('Docker Not available:')
     else:
-        raise exceptions.DockerNotFound(repr(err))
+        raise exceptions.DockerNotFound()

tests/test_test_helpers.py

@@ -0,0 +1,18 @@
+"""who tests the tester's tests?"""
+import pytest
+import _pytest.outcomes
+
+import prosper.common.test_helpers as p_helpers
+import prosper.common.exceptions as exceptions
+
+def test_assert_docker_regular():
+    """make sure p_helpers.assert_docker() raises expected error"""
+    p_helpers.DOCKER_OK = False
+    with pytest.raises(exceptions.DockerNotFound):
+        p_helpers.assert_docker()
+
+def test_assert_docker_xfail():
+    """make sure p_helpers.assert_docker() raises xfail in mode"""
+    p_helpers.DOCKER_OK = False
+    with pytest.raises(_pytest.outcomes.XFailed):
+        p_helpers.assert_docker(xfail=True)