Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loggers cannot have blank configuration in ProsperApplication #26

Closed
lockefox opened this issue Jul 9, 2018 · 1 comment · Fixed by #27
Closed

Loggers cannot have blank configuration in ProsperApplication #26

lockefox opened this issue Jul 9, 2018 · 1 comment · Fixed by #27

Comments

@lockefox
Copy link
Contributor

lockefox commented Jul 9, 2018

`LOGGING.log_format` not found in global config
`LOGGING.discord_recipient` not found in global config
Traceback (most recent call last):
  File "/Users/jpurcell/venvs/.venv_vincent/bin/GetNews", line 11, in <module>
    load_entry_point('vincent-lexicon', 'console_scripts', 'GetNews')()
  File "/Users/jpurcell/source/vincent-lexicon/vincent_crons/GetNews.py", line 172, in run_main
    GetNewsCLI.run()
  File "/Users/jpurcell/venvs/.venv_vincent/lib/python3.6/site-packages/plumbum/cli/application.py", line 500, in run
    retcode = inst.main(*tailargs)
  File "/Users/jpurcell/source/vincent-lexicon/vincent_crons/GetNews.py", line 147, in main
    self.logger.info('hello world')
  File "/Users/jpurcell/venvs/.venv_vincent/lib/python3.6/site-packages/prosper/common/prosper_cli.py", line 83, in logger
    custom_args=id_string
  File "/Users/jpurcell/venvs/.venv_vincent/lib/python3.6/site-packages/prosper/common/prosper_logging.py", line 282, in configure_discord_logger
    discord_obj.webhook(discord_webhook)
  File "/Users/jpurcell/venvs/.venv_vincent/lib/python3.6/site-packages/prosper/common/prosper_logging.py", line 484, in webhook
    raise Exception('Invalid url format, looking for: ' + self.__webhook_url_format)
Exception: Invalid url format, looking for: https://discordapp.com/api/webhooks/(\d+)/([\w-]+)

Need to be able to run without notifications if not supplied

@lockefox
Copy link
Contributor Author

lockefox commented Jul 9, 2018

May require adding logic to understand that {{jinja.template}} counts as blank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant