Refactor error framework #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
andistorm
force-pushed
the
feature/add-error-subtype
branch
from
af1c647
to
0657419
Compare
Classes: * Add ErrorFactory * Add ErrorManagerImpl * Add ErrorManagerReq * Add ErrorStateMonitor * Remove ErrorCommBridge * Remove ErrorManager Move managment of active errors from global manager to each module. Change the interface of raising, clearing and subscribing errors. Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
andistorm
force-pushed
the
feature/add-error-subtype
branch
from
0657419
to
c223541
Compare
andistorm
commented
May 8, 2024
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
hikinggrass
approved these changes
May 14, 2024
|
There should be a version bump in the CMakeLists.txt before merging this :) |
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
hikinggrass
reviewed
May 14, 2024
hikinggrass
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Classes:
Move managment of active errors from global manager to each module.
Change the interface of raising, clearing and subscribing errors.
Requires
v0.2.3in everest-utils