Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrappers for freeze() and unfreeze() #86

Merged
merged 5 commits into from
Dec 23, 2020
Merged

Wrappers for freeze() and unfreeze() #86

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74a4789
Merge pull request #1 from henry090/master
Cdk29 Dec 20, 2020
5459201
Wrapper for freeze and unfreeze function, so the model can be freeze/…
Cdk29 Dec 20, 2020
1e30eb9
Typo in the documentation
Cdk29 Dec 20, 2020
f3fd534
requested changes + typo
Cdk29 Dec 23, 2020
dca9466
additionnal parameters
Cdk29 Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions R/freeze.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
#' \dontrun{
#' learnR %>% freeze()
#' }
freeze <- function(object){
freeze <- function(object, ...){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cdk29 you forgot to add @param to the documentation part. And please change @return Nothing to None.

Copy link
Contributor Author

@Cdk29 Cdk29 Dec 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henry090 Indeed, sorry for that. I have done the requested changes.


args <- list()
args <- list(...)

do.call(object$freeze, args)
message("The model has been freezed")
message("The model has been frozen")

}

Expand All @@ -30,12 +30,12 @@ freeze <- function(object){
#' \dontrun{
#' learnR %>% unfreeze()
#' }
unfreeze <- function(object){
unfreeze <- function(object, ...){

args <- list()
args <- list(...)

do.call(object$unfreeze, args)
message("The model has been unfreezed")
message("The model has been unfrozen")

}

Expand Down
2 changes: 1 addition & 1 deletion man/freeze.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/unfreeze.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.