-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrappers for freeze() and unfreeze() #86
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
74a4789
Merge pull request #1 from henry090/master
Cdk29 5459201
Wrapper for freeze and unfreeze function, so the model can be freeze/…
Cdk29 1e30eb9
Typo in the documentation
Cdk29 f3fd534
requested changes + typo
Cdk29 dca9466
additionnal parameters
Cdk29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
#' Freeze a model | ||
#' | ||
#' @param object A model | ||
#' | ||
#' @return Nothing | ||
#' @export | ||
#' | ||
#' @examples | ||
#' \donrun{ | ||
#' learnR %>% freeze() | ||
#' } | ||
freeze <- function(object){ | ||
|
||
args <- list() | ||
|
||
do.call(object$freeze, args) | ||
message("The model has been freezed") | ||
|
||
} | ||
|
||
#' Unfreeze a model | ||
#' | ||
#' @param object A model | ||
#' | ||
#' @return Nothing | ||
#' @export | ||
#' | ||
#' @examples | ||
#' | ||
#' \donrun{ | ||
#' learnR %>% unfreeze() | ||
#' } | ||
unfreeze <- function(object){ | ||
|
||
args <- list() | ||
|
||
do.call(object$unfreeze, args) | ||
message("The model has been unfreezed") | ||
|
||
} | ||
|
||
|
||
|
||
|
Binary file modified
BIN
-1 Byte
(100%)
inst/python/fastaibuilt/__pycache__/bs_finder.cpython-36.pyc
Binary file not shown.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there could be some parameters in learn$freeze(...). Could you add 3 dots after the
object
argument? Pass these dots to args, then, please. The same for freeze/unfreeze.@Cdk29 could you make the necessary changes, so I merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henry090 I can yes. But the original fastai code cannot have additional argument so I am not sure it is a good idea : https://github.com/fastai/fastai/blob/master/fastai/learner.py#L521
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cdk29 It will not throw an error. It just allows passing something in case of future modifications. So, this is safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henry090 done !