Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vision models #98

Merged
merged 13 commits into from
Dec 24, 2020
Merged

New vision models #98

merged 13 commits into from
Dec 24, 2020

Conversation

Cdk29
Copy link
Contributor

@Cdk29 Cdk29 commented Dec 24, 2020

Here the news models.

I have tried some locally, it works fine a priori.

I took the freedom to rearrange a bit the order of inside R/vision_models.R to see more easily what was missing from https://docs.fast.ai/vision.models.xresnet.html. It will ease the long term maintenance too I think.

@Cdk29
Copy link
Contributor Author

Cdk29 commented Dec 24, 2020

I don't know why there is older commits coming with it. I managed to create a merging conflic with a pyc dependencies that I had to merged.

Edit : here a link explaining the behavior :
https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch

@turgut090
Copy link
Member

@Cdk29 Could you create a new branch and PR from there, please?

@Cdk29
Copy link
Contributor Author

Cdk29 commented Dec 24, 2020

@henry090 it does the same, the old commits came with it, it seems to be the normal yet weird behavior of github.

The files where the previous commit took place remains unchanged.

@turgut090
Copy link
Member

Thanks! Please, open a new branch for new PRs =)

@turgut090 turgut090 merged commit 06e55ee into EagerAI:master Dec 24, 2020
@Cdk29
Copy link
Contributor Author

Cdk29 commented Dec 24, 2020

@henry090 haha okay I will !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants