Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle pop in the webview #233

Merged

Conversation

xhoi-xhafaj
Copy link

No description provided.

Copy link
Contributor

@josemiguelvarela josemiguelvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xhoi-xhafaj!!

@josemiguelvarela josemiguelvarela merged commit 74318c5 into Earlybyte:master May 25, 2023
@Zazo032
Copy link
Contributor

Zazo032 commented May 30, 2023

Hey @xhoi-xhafaj, after calling login(), once the webview open, if I press Android back button, the app gets closed (like it's not popping the webview but the complete app), did I miss anything to implement this?

@xhoi-xhafaj
Copy link
Author

Hi @Zazo032, this behaviour does not happen on the the app where i needed the changes. You are encountering this behaviour in the example project?

@Zazo032
Copy link
Contributor

Zazo032 commented May 30, 2023

I'm encountering it in our app using this repo's master branch (including these changes), in a B2C login flow, I tried adding breakpoints to that part of the code (WillPopScope) but seems like it's not getting triggered, at least in the emulator, I'm trying to figure out why

@xhoi-xhafaj
Copy link
Author

When you open the azure oauth webview can you try to check with "dev tool" if you have the previous screen on the stack ( on the tree ), maybe you have only the azure oauth webview on your tree.

@Zazo032
Copy link
Contributor

Zazo032 commented May 30, 2023

We have a login page with a button that calls login(), when the webview is opened, devtools shows the page still in the tree, it's not disposed, but still seems like it's not getting triggered. I'll try to do some research on why that happens, it's not critical for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants