Add refreshIfAvailable flag to login() #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graknol
changed the title
sladomic
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a chance that the consuming API, client and Azure AD might be out of sync with regards to time.
This creates a temporal dependency when you only depend on the client's current time.
For this reason, robust clients should instead listen for 401 HTTP response codes to then attempt to refresh the access tokens.
This PR enables you to force the use of the refresh token if it is available.
If a refresh token is not available (i.e. due to missing scope), it'll fall back to check the expiry using the client's local time. If that's still valid it'll return the existing access token.
If any of these fail, it'll still show the full web gui flow as a last resort.