Skip to content

Commit

Permalink
1.145 Beta
Browse files Browse the repository at this point in the history 
A beta-test version for the next release. Incorporates the following three major changes:
1. Rectangle sessions. Change Session input to Rectangle. Add a rectangle object to the chart, name it MPR (or MPR<anything>). The session will be drawn inside the rectangle. Drag, resize or add as many rectangles as you want. It will automatically recalculate market profiles inside them.
2. Single Print marking - for market profile regions with only single TPO in them. Set ShowSinglePrint to true, modify color as needed.
3. Prominent Median (POC) marking - set ProminentMedianPercentage to the percentage of possible TPOs the Median needs to contain to count as prominent. Adjust the color as you want.

Please report bugs!
  • Loading branch information
@EarnForex
EarnForex committed Jul 7, 2020
1 parent ff4ff3b commit 9423a59
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 0 deletions.
Binary file modified MarketProfile.mq4
View file
Binary file not shown.
Binary file modified MarketProfile.mq5
View file
Binary file not shown.

9 comments on commit 9423a59

@Heart1010
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Nice addition 👍

  2. Single Print marking 👍 - I've never saw the Single Prints get marked "before" the profile starts - normally only the color is changed for that very first TPO
    So I would draw the Single Prints from
    Time[sessionstart], price, Time[sessionstart-1], price - onetick
    and not from
    Time[sessionstart + 1], price, Time[sessionstart], price - onetick
    I know you then have that problem with overlapping rectangles (changes the color) 😢 - so two options here
    a) deleting the originally rectangles and only show/draw the single print ones
    b) don't draw "extra" single print rectangles on top of the originally rectangles objects but only color the existing/originally rectangles with the single print color (...OBJPROP_COLOR, SinglePrintColor)

  3. I don't really understand that to 100% - can you make an example when using a daily market profile for example - when do a POC gets prominent ❓ 101 percent from what exactly?

@EarnForex
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The idea was to preserve the color of the original TPO at that single print. If I draw a different color on top, the original color is lost.

  2. It depends on what you set the ProminentMedianPercentage parameter to. At 101%, it will never get prominent because a POC cannot contain 101% of all possible TPOs (the best it can do is 100%). For example, if you set it 50% on a daily session and M30 timeframe (48 TPOs total possible in one line), the POC becomes prominent if it contains 24 TPOs or more.

@Heart1010
Copy link

@Heart1010 Heart1010 commented on 9423a59 Jul 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "color is lost" - yes - that's because I've wrote two alternatives how to bypass that "problem" ;)
  2. Thanks - now it's clear!

@EarnForex
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sorry, then I don't understand it. How does it help with preserving the original color of the TPO?

@Heart1010
Copy link

@Heart1010 Heart1010 commented on 9423a59 Jul 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I expressed myself correctly. ;)
Every market profile chart I know (which support showing single prints in another color) looks more or less like this

image

I think your indicator should also show it that way, shouldn't it? So the single print color should be there in the 1st row - not in the row +1 in front of the actual row.

The problem with the "corrupt" color is there when you place a rectangle with color1 above a rectangle with a different color2 - then you get a total different color.

So instead of placing the single print rectangle above the normal rectangle you can do one of the above two mentioned "workarounds".

Hope it's clear/understandable now?

@EarnForex
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear you. But my concern isn't the colors corrupting from overlapping rectangles. I would just change the TPO rectangle's color to the SinglePrintColor (your solution "b"). My concern is that the original color of the TPO would be list whereas it provides useful information - in market profile, the TPO's color encodes its source time (bar). E.g. older TPO's being blue vs. newer ones being red in the default color scheme.

@Heart1010
Copy link

@Heart1010 Heart1010 commented on 9423a59 Jul 9, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I know what you mean now - that's a point. But as said I've never saw marking Single Prints that way.
So why not expanding that Single Prints marking by adding lines to that levels and also use the CheckRayIntersections function to it?
When price at the moment is e.g. 100 and we have Single Prints below say from 95-90 the line should be drawn at bottom area (90).
When price at the moment is e.g. 100 and we have Single Prints above say from 105-110 the line should be drawn at top area (110).

So then a user has the choice to show/mark SingePrints as rectangles in the profile yes/no - and the extra setting to show SinglePrint/LVN (low volume note) lines like with the value are and poc now already there.

@EarnForex
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try 1.146 Beta - it now offers another option to display single print. When Rightside is chosen, if the height of the TPO is big enough, it will just draw a frame around single print ones, preserving their colors.

@Heart1010
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

...now considering also the SinglePrint/LVN lines (incl intersection check) and it's perfect ;) Thanks

Please sign in to comment.