forked from domasx2/sequelize-fixtures
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Ryan Pon
committed
Jul 8, 2015
1 parent
a4c01ad
commit d6cf0ca
Showing
1 changed file
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6cf0ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Can you tell me what problem were you having that these changes fix?
I tested with latest sequelize & postgres, and it looks like that sequelize generates correct sql to test json equality by default using json access operators
d6cf0ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
At the point I made these changes we were still running an older version of Sequelize that didn't properly support json comparisons. We're now on 3.9 so you're probably right that this isn't necessary anymore.
d6cf0ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks!