ms_readleapsecondfile #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test that segfaults when the global leapsecondlist variable is not null, which could happen if a user sets it to a valid pointer or calls ms_readleapsecondfile twice.
Avoid a null pointer dereference that occurs if the global leapsecondlist points to valid memory, which can occur if ms_readleapsecondfile is called twice, by freeing the memory before reading the new list.
|
Great, thank you @pn2200! We had recently discovered this problem internally and I had not yet committed and fix or an issue, so this will save me time. I hope to review this in the next couple of weeks and release an updated. |
|
@chad-iris, I haven't seen any update related to this pull request or the related issue #18. Can you review this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return number of leap seconds read on success, and add a test verifying that behavior. Free leapsecondlist if it has already been allocated, to avoid segfaults when calling ms_readleapsecondfile multiple times.