RingStream entries handled incorrectly due to a C undefined behaviour #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
int64_t hval = (int64_t)0xcbf29ce484222325ULL;
C declaration results in a C undefined behaviour on my platform, because 0xcbf29ce484222325ULL is greater than INT64_MAX on my platform.This C undefined behaviour causes
FVNhash64("NN_SSSSS_LL_CCC/MSEED")
to erroneously return -9223372036854775740 (i.e. 0x8000000000000044) rather than 18422540039308572745 (i.e. 0xffaa028f1765f849) on my platform, which prevents ringserver from handling RingStream entries correctly on my platform.This pull request fixes this C undefined behaviour, so can you please accept this pull request?
Thank you very much for your efforts!