Throws an exception when API responses an error

EasyAbp · Mar 18, 2023 · b52ad7f · b52ad7f
1 parent bd02889
commit b52ad7f
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/common.props b/common.props
@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <LangVersion>latest</LangVersion>
-    <Version>1.3.3</Version>
+    <Version>1.4.0</Version>
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>EasyAbp Team</Authors>

diff --git a/src/EasyAbp.Abp.Sms.TencentCloud/EasyAbp/Abp/Sms/TencentCloud/FailedToSendSmsException.cs b/src/EasyAbp.Abp.Sms.TencentCloud/EasyAbp/Abp/Sms/TencentCloud/FailedToSendSmsException.cs
@@ -0,0 +1,12 @@
+using Volo.Abp;
+
+namespace EasyAbp.Abp.Sms.TencentCloud
+{
+    public class FailedToSendSmsException : AbpException
+    {
+        public FailedToSendSmsException(string code, string message) : base(
+            $"Tencent Cloud API responses an error: [{code}] {message}.")
+        {
+        }
+    }
+}
diff --git a/...Abp.Abp.Sms.TencentCloud/EasyAbp/Abp/Sms/TencentCloud/InvalidTemplateParamSetException.cs b/...Abp.Abp.Sms.TencentCloud/EasyAbp/Abp/Sms/TencentCloud/InvalidTemplateParamSetException.cs
@@ -1,10 +1,11 @@
-using System;
+using Volo.Abp;
 
 namespace EasyAbp.Abp.Sms.TencentCloud
 {
-    public class InvalidTemplateParamSetException : ApplicationException
+    public class InvalidTemplateParamSetException : AbpException
     {
-        public InvalidTemplateParamSetException() : base("TemplateParamSet should be IEnumerable<string>.")
+        public InvalidTemplateParamSetException() : base(
+            "TemplateParamSet should be IEnumerable<string> or JSON string collection.")
         {
         }
     }

diff --git a/src/EasyAbp.Abp.Sms.TencentCloud/EasyAbp/Abp/Sms/TencentCloud/TencentCloudSmsSender.cs b/src/EasyAbp.Abp.Sms.TencentCloud/EasyAbp/Abp/Sms/TencentCloud/TencentCloudSmsSender.cs
@@ -52,8 +52,13 @@ await _settingProvider.GetOrNullAsync(AbpSmsTencentCloudSettings.DefaultSenderId
                 Region = await _settingProvider.GetOrNullAsync(AbpSmsTencentCloudSettings.DefaultRegion)
             };
 
-            await _requester.SendRequestAsync<SendSmsResponse>(request,
+            var response = await _requester.SendRequestAsync<SendSmsResponse>(request,
                 await _settingProvider.GetOrNullAsync(AbpSmsTencentCloudSettings.EndPoint), commonOptions);
+
+            if (response.Error != null)
+            {
+                throw new FailedToSendSmsException(response.Error.Code, response.Error.Message);
+            }
         }
 
         protected virtual string GetStringProperty(SmsMessage smsMessage, string key, string defaultValue = null)