Skip to content

Commit

Permalink
bug #5669 Fix a double translation of tab labels in details view (jav…
Browse files Browse the repository at this point in the history
…iereguiluz)

This PR was merged into the 4.x branch.

Discussion
----------

Fix a double translation of tab labels in details view

Fixes #5657.

As `@sgautier` pointed in #5657, this causes a double translation error. I think the current code doesn't make any sense ... and in other templates, like the form theme, we don't do the same:

https://github.com/EasyCorp/EasyAdminBundle/blob/f8232febc6f17f0e154a512a8683bc3e72f25a31/src/Resources/views/crud/form_theme.html.twig#L416

Commits
-------

a8b668d Fix a double translation of tab labels in details view
  • Loading branch information
javiereguiluz committed Mar 11, 2023
2 parents 12fb30d + a8b668d commit 5e2c374
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Resources/views/crud/detail.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
{%- if tab.customOption('icon') -%}
<i class="fa-fw {{ tab.customOption('icon') }}"></i>
{%- endif -%}
{{ tab.label|trans(domain = ea.i18n.translationDomain)|trans(domain = 'EasyAdminBundle') }}
{{ tab.label|trans(domain = ea.i18n.translationDomain)|raw }}
</a>
</li>
{% endfor %}
Expand Down

0 comments on commit 5e2c374

Please sign in to comment.