Skip to content

Commit

Permalink
minor #5753 Tweak some modal border colors in dark mode (javiereguiluz)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.x branch.

Discussion
----------

Tweak some modal border colors in dark mode

This doesn't change anything. It's just that in dark mode some modal borders look too bright and the close button is hidden. This PR fixes that.

Commits
-------

336ba71 Tweak some modal border colors in dark mode
  • Loading branch information
javiereguiluz committed May 16, 2023
2 parents d63ea66 + 336ba71 commit ce6722a
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 8 deletions.
3 changes: 2 additions & 1 deletion assets/css/easyadmin-theme/base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,8 @@ body.ea-edit .content-header {
color: var(--alert-dark-color);
}
}
.ea-dark-scheme .alert:not(.alert-light), .alert.alert-dark {
.ea-dark-scheme .alert:not(.alert-light), .alert.alert-dark,
.ea-dark-scheme .modal-header {
.btn-close {
filter: invert(1);
}
Expand Down
2 changes: 1 addition & 1 deletion assets/css/easyadmin-theme/variables-bootstrap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ $modal-content-border-color: var(--border-color) !default;
$modal-content-fallback-border-color: var(--border-color) !default;
$modal-backdrop-bg: var(--black) !default;
$modal-backdrop-opacity: .6 !default;
$modal-header-border-color: var(--border-color) !default;
$modal-header-border-color: var(--modal-header-border-color) !default;
$modal-footer-border-color: $modal-header-border-color !default;
$modal-lg: 900px !default;
$modal-md: 500px !default;
Expand Down
2 changes: 2 additions & 0 deletions assets/css/easyadmin-theme/variables-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
--modal-bg: var(--white);
--modal-border-color: var(--gray-200);
--modal-header-bg: var(--gray-50);
--modal-header-border-color: var(--gray-300);
--modal-footer-bg: var(--gray-100);
--modal-title-color: var(--gray-700);
--form-label-color: var(--gray-800);
Expand Down Expand Up @@ -439,6 +440,7 @@
--modal-bg: var(--true-gray-800);
--modal-border-color: var(--true-gray-600);
--modal-header-bg: var(--true-gray-900);
--modal-header-border-color: var(--true-gray-600);
--modal-footer-bg: var(--true-gray-700);
--modal-title-color: var(--true-gray-400);
--pagination-disabled-color: var(--true-gray-600);
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/Resources/public/entrypoints.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"entrypoints": {
"app": {
"css": [
"/app.1d0fe5a5.css",
"/app.1d0fe5a5.rtl.css"
"/app.404e52fc.css",
"/app.404e52fc.rtl.css"
],
"js": [
"/app.b5acb2f0.js"
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/public/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"app.css": "app.1d0fe5a5.css",
"app.rtl.css": "app.1d0fe5a5.rtl.css",
"app.css": "app.404e52fc.css",
"app.rtl.css": "app.404e52fc.rtl.css",
"app.js": "app.b5acb2f0.js",
"form.js": "form.fc39362b.js",
"page-layout.js": "page-layout.3347892e.js",
Expand Down

0 comments on commit ce6722a

Please sign in to comment.