This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Update EasyLogFormatter.php #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added root namespace for \Throwable. Without that i got: PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to EasyCorp\EasyLog\EasyLogFormatter::formatThrowable() must be an instance of EasyCorp\EasyLog\Throwable, instance of Symfony\Component\Security\Core\Exception\AccessDeniedException given
|
I would prefer to see a That said I think this would lead to an error in <7.0 so I would require |
Closed
|
Hmm I'm having this same with |
|
And now looked that change - makes sense :D |
vudaltsov
approved these changes
Jun 25, 2018
Closed
|
@javiereguiluz , looking forward to this being merged! |
|
Note that a very minimal test suite could prevent such issues. |
|
Thanks for this and sorry for having taken so long to merge it. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 27, 2018
This PR was merged into the master branch. Discussion ---------- Update EasyLogFormatter.php Added root namespace for \Throwable. Without that i got: PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to EasyCorp\EasyLog\EasyLogFormatter::formatThrowable() must be an instance of EasyCorp\EasyLog\Throwable, instance of Symfony\Component\Security\Core\Exception\AccessDeniedException given Commits ------- 41b6783 Update EasyLogFormatter.php
|
This fix was included in the just released 1.0.6 version (https://github.com/EasyCorp/easy-log-handler/releases/tag/v1.0.6) |
|
Thanks a lot @javiereguiluz ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added root namespace for \Throwable. Without that i got:
PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to EasyCorp\EasyLog\EasyLogFormatter::formatThrowable() must be an instance of EasyCorp\EasyLog\Throwable, instance of Symfony\Component\Security\Core\Exception\AccessDeniedException given