feat(component): Add location & role to test data #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `Test component` to contain locations and roles for testing our viewer & editor.
tuckerzp
added a commit
to EasyDynamics/oscal-editor-deployment
that referenced
this pull request
Mar 22, 2023
To avoid regression after EasyDynamics/oscal-react-library#728 is merged in, this tests that locations and roles display properly. It will require changes from EasyDynamics/oscal-demo-content#35 for the tests to pass.
2 tasks
|
What did you actually change? The diff is a mess here. |
tuckerzp
commented
Mar 23, 2023
Comment on lines
+9
to
+37
| "roles" : [ { | ||
| "id" : "creator", | ||
| "title" : "Document creator", | ||
| "short-name" : "creator", | ||
| "description" : "Creates documents describing the system" | ||
| }, { | ||
| "id" : "contact", | ||
| "title" : "Contact" | ||
| } ], | ||
| "locations" : [ { | ||
| "uuid" : "54e8923b-56d2-46f1-bb97-9c6f734d9d9e", | ||
| "title" : "NIST", | ||
| "address" : { | ||
| "addr-lines" : [ "100 Bureau Drive", "Mail Stop 8970" ], | ||
| "city" : "Gaithersburg", | ||
| "state" : "MD", | ||
| "postal-code" : "20899-8970" | ||
| }, | ||
| "email-addresses" : [ "itl_inquiries@nist.gov" ], | ||
| "telephone-numbers" : [ { | ||
| "type" : "office", | ||
| "number" : "301-975-8616" | ||
| } ], | ||
| "urls" : [ "https://www.nist.gov/", "https://www.nist.gov/itl/ssd/contact-us" ], | ||
| "remarks" : "Working with industry and academia to enhance economic security and improve our quality of life." | ||
| }, { | ||
| "uuid" : "6c01ae87-5410-41af-87cd-3253dd7ccfc7", | ||
| "address" : { } | ||
| } ], |
There was a problem hiding this comment.
What did you actually change? The diff is a mess here.
@kylelaker This is actual change. Saving it in the Editor changed the formatting.
There was a problem hiding this comment.
For roles, I added a short-name & description to Document Creator.
There was previously no locations.
kylelaker
pushed a commit
to EasyDynamics/oscal-editor-deployment
that referenced
this pull request
Mar 23, 2023
To avoid regression after EasyDynamics/oscal-react-library#728 is merged in, this tests that locations and roles display properly. It will require changes from EasyDynamics/oscal-demo-content#35 for the tests to pass.
kylelaker
added a commit
to EasyDynamics/oscal-editor-deployment
that referenced
this pull request
Mar 23, 2023
To avoid regression after EasyDynamics/oscal-react-library#728 is merged in, this tests that locations and roles display properly. It will require changes from EasyDynamics/oscal-demo-content#35 for the tests to pass. --------- Co-authored-by: Kyle Laker <klaker@easydynamics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
Test componentto contain locations and rolesfor testing our viewer & editor.