EGRC-263: OSCAL Viewer Branding #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgauss
requested review from
kylelaker,
folksgl,
Bronstrom,
tuckerzp,
hreineck,
zclarkEDC and
kkennedy26
|
Reviewing now. |
zclarkEDC
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Branding works on Edge and Chrome.
There is one slight display bug, the EDC logo gets blurry when I use a larger monitor.
However, this minor display bug isn't too concerning.
To resolve this issue, switching logo-header.png to the .svg equivalent could work.
kylelaker
suggested changes
Jul 7, 2021
zclarkEDC
approved these changes
Jul 7, 2021
kylelaker
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.