-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to reflect oscal-viewer & oscal-react-library changes #106
Conversation
@@ -33,9 +39,12 @@ npm start | |||
|
|||
## Testing | |||
|
|||
Within the `example/src` directory, run the following comands to run application tests and linter checks, respectively: | |||
Within the `example/src` directory, run the following commands to run application tests and linter checks, respectively: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rephrase this sentence.
It might be good to consider adding a link to the |
@Bronstrom, can you load the FedRAMP moderate profile for the Profile Viewer screenshot? |
|
Are we planning to make the FedRAMP moderate profile going to be the default in the future? If so, I'll update the description as well. |
Not yet. |
|
||
|
||
TODO: Update details about OSCAL Viewer (EGRC-422) | ||
An open sandbox environment of the project can be viewed at https://oscal-viewer.msd.easydynamics.com/catalog. | ||
|
||
|
||
## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bronstrom, can we order the screenshots from 'bottom to top' in terms of the OSCAL 'stack':
- Catalog
- Profile
- Component Definition
- SSP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to reorder their names as well when they are mentioned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is mad:
The
README.md
inexample/
was outdated and didn't list some of the new features of the Viewer. More details were clarified about the Viewer and the sandbox environment is now listed with a link.