EGRC-140: Added test of component control implementation description #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zclarkEDC
approved these changes
Mar 17, 2021
| @@ -116,7 +116,7 @@ function ReplacedProseWithByComponentParameterValue(props) { | |||
| <Typography> | |||
| <Tooltip title={ | |||
| <Typography variant="body2">{description}</Typography> | |||
| }><Link>{props.label}</Link></Tooltip> | |||
| }><Link href={''}>{props.label}</Link></Tooltip> | |||
There was a problem hiding this comment.
Setting an empty href may lead to future accessibility concerns, but my console didn't explicitly have any warnings so I will approve this PR.
hkps
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review PRs #4 and #13 first.
Adds test of component control implementation description which requires hovering/clicking the statement label.
This also required adding an empty
hrefto the tooltipLinkto give it an accessible role.I haven't investigated
devDependenciesso I'm not sure that move is strictly needed.