Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EGRC-241: Create OSCAL CatalogGroupControlGuidance test file, test for display of control guidance #12

Merged
merged 6 commits into from
Mar 17, 2021
Merged

EGRC-241: Create OSCAL CatalogGroupControlGuidance test file, test for display of control guidance #12

merged 6 commits into from
Mar 17, 2021

Conversation

kkennedy26
Copy link
Contributor

Running tests:
npm install
npm test

hkps
hkps reviewed Mar 17, 2021
View reviewed changes
src/OSCALMetadata.js Outdated Show resolved Hide resolved
hkps
hkps approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@hkps hkps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passed, but my console is throwing a lot of errors tracing back to Material-UI, for some reason. I'd suggest seeing investigating that a bit, and being careful merging this branch.

@kkennedy26 kkennedy26 merged commit b63689c into EGRC-139 Mar 17, 2021
@kkennedy26 kkennedy26 deleted the EGRC-241 branch March 17, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgauss rgauss rgauss approved these changes

@hkps hkps hkps approved these changes

@zclarkEDC zclarkEDC zclarkEDC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kkennedy26 @rgauss @hkps @zclarkEDC