-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Up GitHub Actions for Publishing Storybook to GitHub Pages #130
Conversation
Created gh-pages.yml in workflows This sets up the GitHub actions to publish the Storybook docs to GitHub pages on each push to develop.
Update the Actions in gh-pages.yml to run on a push to EGRC-275 so that it will run properly after merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes would be good here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to talk about
And as a last thing to discuss, the Action we're using has support for pushing to a different repo so that we could create a repo like |
Added a TODO comment to remove `EGRC-275` from the branches that the action is triggered on a push once this gets merged. Removed fetch-depth 0, which would unnecessarily grab the entire history. Added `single-commit: true` to the deploy action, in order to keep the commits cleaner.
Added properties to the GitHub actions for publishing Storybook that set up a name and email for the author of the commits made by the GitHub actions script.
Excellent job, thank you. |
Created gh-pages.yml in workflows
This sets up the Github actions to publish the Storybook docs
to Github pages on each push to develop.