EGRC-248: Test SSP System Characteristics #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkps
reviewed
Mar 17, 2021
hkps
reviewed
Mar 17, 2021
hkps
reviewed
Mar 17, 2021
| ] | ||
| } | ||
| ], | ||
| "description": "Example information type", |
There was a problem hiding this comment.
Other descriptions have periods, and this one doesn't—not sure whether that's something we want to keep consistent
There was a problem hiding this comment.
@hkps, sure, can you create commit suggestions for it/them?
hkps
approved these changes
Mar 17, 2021
Co-authored-by: Hannah Posey-Scholl <hkps.hannah@gmail.com>
Co-authored-by: Hannah Posey-Scholl <hkps.hannah@gmail.com>
kkennedy26
approved these changes
Mar 17, 2021
Co-authored-by: kkennedy26 <78984988+kkennedy26@users.noreply.github.com>
hkps
reviewed
Mar 17, 2021
Co-authored-by: Hannah Posey-Scholl <hkps.hannah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for System Characteristics at both that component's level and within the SSP.
Also: