Add withdrawn check for the Controls #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to see if the Control is withdrawn.
snorouzzadeh
requested review from
rgauss,
tuckerzp,
Bronstrom,
folksgl,
hreineck,
kkennedy26,
kylelaker,
mikeisen1 and
zclarkEDC
kylelaker
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Nice fix! Thank you!
I wondered whether it'd be worth it to write a test to prevent future regressions but since this seems to possibly be NIST SP 800-53-specific anyway and since it returns some CSS that we may choose to change, I think it's probably not worth testing.
tuckerzp
approved these changes
Jul 28, 2021
rgauss
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to see if the Control is withdrawn.