Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EGRC-249: Test SSP System Implementation #15

Merged
merged 1 commit into from
Mar 18, 2021
Merged

EGRC-249: Test SSP System Implementation #15

merged 1 commit into from
Mar 18, 2021

Conversation

rgauss
Copy link
Contributor

@rgauss rgauss commented Mar 17, 2021

Adds SSP system implementation tests at both the OSCALSystemImplementation and OSCALSsp component levels.

hkps
hkps approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@hkps hkps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSCAL viewer ran, tests passed, and the code looks good.

kkennedy26
kkennedy26 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@kkennedy26 kkennedy26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all passed. Couldn't find any errors within any of the code. Looks good!

@rgauss rgauss merged commit 62021f7 into EGRC-130 Mar 18, 2021
@rgauss rgauss deleted the EGRC-249 branch March 18, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkps hkps hkps approved these changes

@kkennedy26 kkennedy26 kkennedy26 approved these changes

@zclarkEDC zclarkEDC Awaiting requested review from zclarkEDC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgauss @hkps @kkennedy26