Render Skeleton When Loading Profile Viewer #152
Conversation
Modified the way the profile viewer loads to show only the skeleton card when the page is loading in; this fixes the issues with the skeleton not rendering at all, as well as making it a bit more clear that the page is still loading content.
The Back Matter and Metadata components previously were rendered alonside the skeleton. Now that those components do not render right away, the tests for those components had to be updated; the test functions were changed to use `await` and a timeout of 10000ms to wait on the page to load before finding the elements.
hreineck
requested review from
rgauss,
kkennedy26,
kylelaker,
snorouzzadeh and
mikeisen1
This reverts commit 4b1e604.
hreineck
changed the title
When the controls are still being resolved, display the back matter and metadata components alongside the skeleton, because they will be fully loaded before the controls are resolved.
|
In the previous commit that initially sets up the skeleton, |
Change the skeleton to render two rectangles in the place of the "imported controls." This more accurately matches the style of the page when it loads.
This reverts commit 4397e9c.
There was a problem hiding this comment.
Comparing the two different styles, it definitely looks better this way having the skeleton for loading imported controls instead of the whole page. Also, it isn't part of this task, but there is a console error for a key prop when running tests. I don't know if there is an issue for it already.
Out of curiosity, was console error there before this branch was created? Just don't want to unintentionally add errors to fix later. |
It must have been there before this branch, but not exactly sure where or when this error occurred. |
Modified the way the profile viewer loads to show only the skeleton
card when the page is loading in; this fixes the issues with the
skeleton not rendering at all, as well as making it a bit more clear
that the page is still loading content.