EGRC-265: Fix Key Prop Errors #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkennedy26
reviewed
Mar 18, 2021
| @@ -46,7 +46,7 @@ export default function OSCALControlImplementation(props) { | |||
| <List className={classes.OSCALControlImplementationImplReqList}> | |||
| {props.controlImplementation.['implemented-requirements'].map(implementedRequirement => ( | |||
| <OSCALControlImplementationImplReq implementedRequirement={implementedRequirement} | |||
| components={props.components} controls={props.controls} childLevel={0} /> | |||
| components={props.components} controls={props.controls} childLevel={0} key={implementedRequirement.uuid} /> | |||
There was a problem hiding this comment.
All of the Key props errors were solved except for one referring to this key. I resolved it by concatenating a string onto it like we have in previous keys to make them more specific.
There was a problem hiding this comment.
@kkennedy26, what were you doing to see the warning? I wasn't getting any.
There was a problem hiding this comment.
@rgauss I just cloned the repo, switched to the 245 branch, and did npm install, npm test.
There was a problem hiding this comment.
I got that warning as well, and resolved it the same way
There was a problem hiding this comment.
OK, see it now. It's actually bad test data, uuid is required. Just committed a fix.
hkps
approved these changes
Mar 18, 2021
kkennedy26
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.