Update GitHub super linter #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelaker
force-pushed
the
feature/update-github-super-linter
branch
2 times, most recently
from
0f85883
to
e0dfa67
Compare
kylelaker
added
dependencies
rgauss
approved these changes
Dec 29, 2021
Newer versions of the super linter changed to using eslint for JSON linting; however, our eslintrc doesn't specify the JSON plugin. This adds it as a dependency and to the configuration file to ensure that the plugin is available and JSON can be parsed correctly.
This was identified by `eslint` as something that should be a production rather than dev dependencies. This is due to it being imported and executed directly via `index.js`.
This resolves linter errors that were identified after fixing the plugin.
This ensures that the example app is captured correctly in the eslint config and that the app complies with the linting requirements.
kylelaker
force-pushed
the
feature/update-github-super-linter
branch
from
047dc02
to
a3a423e
Compare
hreineck
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of the super linter changed to using eslint for JSON
linting; however, our eslintrc doesn't specify the JSON plugin. This
adds it as a dependency and to the configuration file to ensure that the
plugin is available and JSON can be parsed correctly.